linux-kernel - Re: [GIT PULL] ib_srpt: Initial SRP Target merge for v3.2-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-p0gLueksp7a8RVm9A1Qe_9xc-fNSNX0NY0W7CNtGnSYw@mail.gmail.com>
Date:	Sun, 6 Nov 2011 14:20:47 +0100
From:	Bart Van Assche <bvanassche@....org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	target-devel <target-devel@...r.kernel.org>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Roland Dreier <roland@...estorage.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [GIT PULL] ib_srpt: Initial SRP Target merge for v3.2-rc1

On Sun, Nov 6, 2011 at 11:09 AM, Nicholas A. Bellinger
<nab@...ux-iscsi.org> wrote:
> We have also discussed srpt_service_guid a bit before, which you
> indicated needed to stay in current code as global scope, and presumably
> should not change value after loading.  Looking at the actual usage, one
> post merge improvement we can consider is seeing if it's possible to
> move ib_cm_listen() out of srpt_add_one() and have it driven instead by
> configfs context in order to optionally set srpt_service_guid on a per
> target endpoint basis to get us some more flexibility.

ib_sprt defines a single I/O controller profile and hence there should
be exactly one GUID associated with it.

> For the "last WQE" you've mentioned, I'm happy to accept a patch to
> address this as you know the code better than me.  Otherwise, I'll be
> digging this out of your out-of-tree code as a seperate item and
> figuring out how to reproduce and test this special case.

I'll post a patch to address last WQE handling.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/