linux-kernel - Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111107100446.GG4265@legolas.emea.dhcp.ti.com>
Date:	Mon, 7 Nov 2011 12:04:47 +0200
From:	Felipe Balbi <balbi@...com>
To:	"Voss, Nikolaus" <N.Voss@...nmann.de>
Cc:	"'balbi@...com'" <balbi@...com>,
	"'linux-i2c@...r.kernel.org'" <'linux-i2c@...r.kernel.org'>,
	"'linux-arm-kernel@...ts.infradead.org'" 
	<'linux-arm-kernel@...ts.infradead.org'>,
	"'nicolas.ferre@...el.com'" <nicolas.ferre@...el.com>,
	"'plagnioj@...osoft.com'" <plagnioj@...osoft.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	ben-linux@...ff.org
Subject: Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

On Mon, Nov 07, 2011 at 11:01:27AM +0100, Voss, Nikolaus wrote:
> Hi,
> 
> > IMHO, you should split this patch into three or more smaller patches.
> > You're doing lots of different things in one commit and it'll be a pain to
> > bisect should this cause any issues to anyone.
> 
> I didn't split the patch because it is virtually a complete rewrite.
> Due to the severe limitations of the old driver, I think it should
> replace the old driver.

The final decision is up to Ben and/or Jean but I think we should
always have incremental patches, not sure if we should allow big patches
for the reasons above.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)