linux-kernel - Re: [PATCH 1/4] lockdep: lock_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320669279.18053.29.camel@twins>
Date:	Mon, 07 Nov 2011 13:34:39 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	linux-kernel@...r.kernel.org, sergey.senozhatsky@...il.com,
	bp@...en8.de, Ingo Molnar <mingo@...e.hu>,
	Tejun Heo <tj@...nel.org>, David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 1/4] lockdep: lock_set_subclass() fix

On Fri, 2011-11-04 at 17:26 +0800, Yong Zhang wrote:
> Since commit f59de89 [lockdep: Clear whole lockdep_map on initialization],
> lockdep_init_map() will clear all the struct. But it will break
> lock_set_class()/lock_set_subclass(). A typical race condition
> is like below:

This is a horridly ugly patch, why not simply revert that memset commit?
I really can't see the point of that, and keeping the name/key pointers
around (which can only be over-written with the same values, right?)
would also cure the problem.

Sadly the changelog is completely devoid of useful information (which is
my own damn fault, I should never have accepted the patch in that form),
so I can't actually comment on what it was supposed to fix.

Arguably kmemcheck is on crack or so since both name and key pointers
should be in .data so there cannot be a leak by copying the thing over.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/