linux-kernel - Re: [PATCH] rtl8192e: Don't copy huge struct by value (and make it const).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EB80D92.8050507@lwfinger.net>
Date:	Mon, 07 Nov 2011 10:55:46 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Jesper Juhl <jj@...osbits.net>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Andrea Merello <andreamrl@...cali.it>,
	Mike McCormack <mikem@...g3k.org>,
	Greg Kroah-Hartman <gregkh@...e.de>, netdev@...r.kernel.org
Subject: Re: [PATCH] rtl8192e: Don't copy huge struct by value (and make it
 const).

On 11/06/2011 05:21 PM, Jesper Juhl wrote:
> rtllib_is_shortslot() takes one argument - a struct that's more than a
> kilobyte large. It should take a pointer instead of copying such a
> huge struct - and the argument might as well be declared 'const' now
> that we are at it, since it is not modified. This patch makes these
> changes.
>
> Signed-off-by: Jesper Juhl<jj@...osbits.net>

Acked-by: Larry Finger <Larry.Finger@...inger.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/