linux-kernel - Re: [PATCH 4/5] IIO:hwmon interface client driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB817C6.5070503@kernel.org>
Date:	Mon, 07 Nov 2011 17:39:18 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	guenter.roeck@...csson.com
CC:	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	"arnd@...db.de" <arnd@...db.de>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"lars@...afoo.de" <lars@...afoo.de>,
	"maxime.ripard@...e-electrons.com" <maxime.ripard@...e-electrons.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"zdevai@...il.com" <zdevai@...il.com>,
	Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH 4/5] IIO:hwmon interface client driver.

>> +static int __devexit iio_hwmon_remove(struct platform_device *pdev)
>> +{
>> +	struct iio_hwmon_state *st = platform_get_drvdata(pdev);
>> +
>> +	hwmon_device_unregister(st->hwmon_dev);
>> +	sysfs_remove_group(&pdev->dev.kobj, &st->attr_group);
>> +	iio_hwmon_free_attrs(st);
>> +	kfree(st->attrs);
>> +	iio_channel_release_all(st->channels);
>> +
> 
> Either I missed it before, or I am missing something now ... should
> there be kfree(st) here ?
> 
> Thanks,
> Guenter

Gah! you are quite right.  Good spot.  I'll fix that one up and repost
this individual patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/