linux-kernel - Re: [GIT PULL rcu/next] RCU commits for 3.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111107175523.GK2332@linux.vnet.ibm.com>
Date:	Mon, 7 Nov 2011 09:55:23 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Stephane Eranian <eranian@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>, Ingo Molnar <mingo@...e.hu>,
	eric.dumazet@...il.com, shaohua.li@...el.com, ak@...ux.intel.com,
	mhocko@...e.cz, alex.shi@...el.com, efault@....de,
	linux-kernel@...r.kernel.org, Paul Turner <pjt@...gle.com>
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.1

On Mon, Nov 07, 2011 at 06:09:49PM +0100, Peter Zijlstra wrote:
> On Mon, 2011-11-07 at 08:56 -0800, Paul E. McKenney wrote:
> > 
> > If this really is a false positive, what should be used to get rid of
> > the splats? 
> 
> 
> Probably something slightly less horrid than the below.. ;-)

Hmmm...  Could the "1" below be replaced by the task's reference count?
Probabilistic, but should eventually catch it.

							Thanx, Paul

> ---
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index d1a1bee..8f05201 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -229,7 +229,7 @@ static void perf_ctx_unlock(struct perf_cpu_context *cpuctx,
>  static inline struct perf_cgroup *
>  perf_cgroup_from_task(struct task_struct *task)
>  {
> -	return container_of(task_subsys_state(task, perf_subsys_id),
> +	return container_of(task_subsys_state_check(task, perf_subsys_id, 1),
>  			struct perf_cgroup, css);
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/