linux-kernel - RE: [Patch] Increase USBFS Bulk Transfer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BADF286A08026E4DAFA9622608E3D8DB063CE25890@rosser.pointgrey.local>
Date:	Mon, 7 Nov 2011 11:16:58 -0800
From:	Tim Vlaar <Tvlaar@...rey.com>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Alan Stern <stern@...land.harvard.edu>
CC:	Greg KH <greg@...ah.com>,
	Markus Rechberger <mrechberger@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	USB list <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: [Patch] Increase USBFS Bulk Transfer size

Hi Sarah,

One of our cameras can produce 60MB images.  We usually queue up 10 images.  In Windows we have had customers queue up 100s of images at 2-3MB/image, but not at 60MB at a time ... yet.  That could easily amount to 60x10 = 600MB of in flight data or more.  Should there be a limit as long as there is memory available?

Thanks
Tim

-----Original Message-----
From: Sarah Sharp [mailto:sarah.a.sharp@...ux.intel.com] 
Sent: Monday, November 07, 2011 10:53 AM
To: Alan Stern; Tim Vlaar
Cc: Greg KH; Markus Rechberger; Alan Cox; USB list; LKML
Subject: Re: [Patch] Increase USBFS Bulk Transfer size

On Fri, Oct 14, 2011 at 08:33:29AM -0600, Greg KH wrote:
> On Fri, Oct 14, 2011 at 10:05:41AM -0400, Alan Stern wrote:
> > No, a much better approach is to remove all limits on individual 
> > transfer sizes and instead have a global limit on the total amount 
> > of all usbfs buffers in use at any time.  Maybe something like 16 
> > MB; at SuperSpeed, that's about about 30 ms worth of data.
> 
> That sounds quite reasonable.

Alan, won't this global limit on the usbfs URB buffer size effect userspace drivers that are currently allocating large amounts of buffers, but still respecting individual buffer limit of 16KB?  It seems like the patch has the potential to break userspace drivers.

I think that Point Grey's USB 3.0 webcam will be attempting to queue a series of bulk URBs that will be bigger than your 16MB global limit.

Tim, what is the total size of buffers that will be in flight at any one time for your device?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/