linux-kernel - Re: [patch 1/5]thp: improve the error code path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320643049.22361.204.camel@sli10-conroe>
Date:	Mon, 07 Nov 2011 13:17:29 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Andrea Arcangeli <aarcange@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/5]thp: improve the error code path

On Wed, 2011-10-26 at 09:48 +0800, Shaohua Li wrote:
> On Tue, 2011-10-25 at 19:44 +0800, Andrea Arcangeli wrote:
> > Hello,
> > 
> > On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> > > +#ifdef CONFIG_SYSFS
> > > +	sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> > > +remove_hp_group:
> > > +	sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> > > +delete_obj:
> > > +	kobject_put(hugepage_kobj);
> > >  out:
> > > +#endif
> > 
> > Adding an ifdef is making the code worse, the whole point of having
> > these functions become noops at build time is to avoid having to add
> > ifdefs in the callers.
> yes, but hugepage_attr_group is defined in CONFIG_SYSFS. And the
> functions are inline functions. They really should be a '#define xxx'.
ping, any comments for the 5 patches?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/