linux-kernel - Re: [PATCH] ipc/mqueue: simplify reading msgqueue limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320704156.3009.0.camel@offbook>
Date:	Mon, 07 Nov 2011 19:15:56 -0300
From:	Davidlohr Bueso <dave@....org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jiri Slaby <jslaby@...e.cz>,
	Wanlong Gao <gaowanlong@...fujitsu.com>,
	Nick Piggin <npiggin@...nel.dk>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ipc/mqueue: simplify reading msgqueue limit

ping?

On Thu, 2011-11-03 at 15:31 -0300, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@....org>
> 
> Because the current task is being used to get the limit, we can simply use rlimit() instead of task_rlimit().
> 
> Signed-off-by: Davidlohr Bueso <dave@....org>
> ---
>  ipc/mqueue.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 2e0ecfc..c0e4fbb 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -127,7 +127,6 @@ static struct inode *mqueue_get_inode(struct super_block *sb,
>  
>  	if (S_ISREG(mode)) {
>  		struct mqueue_inode_info *info;
> -		struct task_struct *p = current;
>  		unsigned long mq_bytes, mq_msg_tblsz;
>  
>  		inode->i_fop = &mqueue_file_operations;
> @@ -158,7 +157,7 @@ static struct inode *mqueue_get_inode(struct super_block *sb,
>  
>  		spin_lock(&mq_lock);
>  		if (u->mq_bytes + mq_bytes < u->mq_bytes ||
> -		    u->mq_bytes + mq_bytes > task_rlimit(p, RLIMIT_MSGQUEUE)) {
> +		    u->mq_bytes + mq_bytes > rlimit(RLIMIT_MSGQUEUE)) {
>  			spin_unlock(&mq_lock);
>  			/* mqueue_evict_inode() releases info->messages */
>  			ret = -EMFILE;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/