linux-kernel - Re: [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EB85A29.3010604@jp.fujitsu.com>
Date:	Mon, 07 Nov 2011 14:22:33 -0800
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	rientjes@...gle.com
CC:	mhocko@...e.cz, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	oleg@...hat.com, yinghan@...gle.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN

(11/7/2011 1:54 PM), David Rientjes wrote:
> On Fri, 4 Nov 2011, Michal Hocko wrote:
> 
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index e916168..4883514 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -185,6 +185,9 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
>>  	if (!p)
>>  		return 0;
>>  
>> +	if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>> +		return 0;
>> +
>>  	/*
>>  	 * The memory controller may have a limit of 0 bytes, so avoid a divide
>>  	 * by zero, if necessary.
> 
> This leaves p locked, you need to do task_unlock(p) first.
> 
> Once that's fixed, please add my
> 
> 	Acked-by: David Rientjes <rientjes@...gle.com>

Agreed.
	Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/