linux-kernel - Re: [PATCH 1/9] staging/comedi/jr3: Convert pci_table entries to PCI_DEVICE (if PCI_ANY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111107055100.GV4682@mwanda>
Date:	Mon, 7 Nov 2011 08:51:00 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	Ian Abbott <abbotti@....co.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] staging/comedi/jr3: Convert pci_table entries to
 PCI_DEVICE (if PCI_ANY_ID is used)

On Mon, Nov 07, 2011 at 12:53:59AM +0100, Peter Huewe wrote:
> This patch converts pci_table entries to use the PCI_DEVICE macro,
> if .subvendor and .subdevice are set to PCI_ANY_ID,
> and thus improves readablity.
> 
> Since the driver_data field isn't used anywhere we can also drop the
> assignments for class, class_mask and driver_data.
> 

The other reason we can remove them is that C will initialize them
to zero by default in this case.  So the new code is just shorter to
write and doesn't change anything.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)