linux-kernel - Re: [PATCH] Input: convert obsolete strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d3d4fok0.fsf@emc.com.tw>
Date:	Mon, 07 Nov 2011 14:13:03 +0800
From:	JJ Ding <jj_ding@....com.tw>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	JJ Ding <dgdunix@...il.com>
Subject: Re: [PATCH] Input: convert obsolete strict_strtox to kstrtox

Hi Dmitry,

Thanks for the hint. I will send a new patch.

Btw, there are still some simple_strtox uses floating around. Namely:

drivers/input/joystick/analog.c:735:            analog_options[i] = simple_strtoul(js[i], &end, 0);
drivers/input/mouse/sentelic.c:415:     reg = simple_strtoul(buf, &rest, 16);
drivers/input/touchscreen/gunze.c:71:   input_report_abs(dev, ABS_X, simple_strtoul(gunze->data + 1, NULL, 10));
drivers/input/touchscreen/gunze.c:72:   input_report_abs(dev, ABS_Y, 1024 - simple_strtoul(gunze->data + 6, NULL, 10));

But I am not quite sure if it's safe to convert along the way. Is it OK
to convert these?

Thanks,
jj

On Sun, 6 Nov 2011 21:55:40 -0800, Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
> Hi JJ,
> 
> On Mon, Nov 07, 2011 at 11:12:50AM +0800, JJ Ding wrote:
> > From: JJ Ding <dgdunix@...il.com>
> > 
> > With commit 67d0a0754455f89ef3946946159d8ec9e45ce33a we mark strict_strtox
> > as obsolete. Convert all remaining such uses in drivers/input/.
> 
> Most of these users do not want long data, they just want an int, but
> strict_strtouint was not available. Since we have kstrtouint now it
> would be nice to use it.
> 
> Thanks.
> 
> -- 
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/