linux-kernel - Re: [PATCH] [staging] iio, adc: Do not leak memory in ad7280_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Nov 2011 08:37:20 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Jonathan Cameron <jic23@...nel.org>
CC:	Jesper Juhl <jj@...osbits.net>, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH] [staging] iio, adc: Do not leak memory in ad7280_event_handler()

On 11/06/2011 10:49 PM, Jonathan Cameron wrote:
> On 11/06/2011 09:49 PM, Jesper Juhl wrote:
>> If ad7280_read_all_channels() returns <0 then we'll leak the memory
>> allocated to 'channels' when we return and that variable goes out of
>> scope.
>> This patch fixes the leak.
>>
> Looks right to me - good spot. Only choice is whether a single exit
> point makes sense rather than undwinding it here? Michael?
> I'm happy with either solution, hence the ack.

A similar patch has already been sent last week and should be in Gregs queue.
See: http://comments.gmane.org/gmane.linux.kernel.iio/2433

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/