linux-kernel - Re: [PATCH] ramoops: Add a device file for ramoops buffer access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Nov 2011 16:36:22 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Bryan Freed <bfreed@...omium.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	msb@...omium.org, marco.stornelli@...il.com, seiji.aguchi@....com
Subject: Re: [PATCH] ramoops: Add a device file for ramoops buffer access.

Hi Bryan,

On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote:
> Add a /dev/ramoops device file that gives direct access to ramoops buffers.
> This interface is cleaner than using /dev/mem to access the buffers because
> we no longer need to lseek() or (for ARM) mmap() to an address specified in
> the sysfs mem_address file.

This looks pretty good, except that I'd also want to remove all the module
parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a
malicious root user loading this module to spy on RAM via the new
interface).

Last week I actually wrote an entire seq_file interface for ramoops[1], but
it seems it shouldn't live in /proc, so it needs to be reworked a bit to
live in /dev, as you have it.

Perhaps we could merge our efforts?

-Kees

[1] https://gerrit.chromium.org/gerrit/#change,11242

-- 
Kees Cook
ChromeOS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/