linux-kernel - Re: [PATCH 1/1] rc: Fix input deadlock and transmit error in redrat3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111108171122.GA4682@mwanda>
Date:	Tue, 8 Nov 2011 20:11:23 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andrew Vincer <Andrew.Vincer@...rat.co.uk>
Cc:	"mchehab@...radead.org" <mchehab@...radead.org>,
	"jarod@...hat.com" <jarod@...hat.com>,
	"error27@...il.com" <error27@...il.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] rc: Fix input deadlock and transmit error in redrat3
 driver

On Tue, Nov 08, 2011 at 04:43:45PM +0000, Andrew Vincer wrote:
> Fixed submit urb logic so hardware doesn't hang trying to transmit
> signal data
> 
> Removed unneeded enable/disable detector commands in
> redrat3_transmit_ir (the hardware does this anyway) and converted
> arguments to unsigned as per 5588dc2
> 

This would be easier to review it you put the changes to enable and
disable into one patch and the changes so that we now measure the
buffer length in bytes instead of ints into a second patch.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)