linux-kernel - Re: Linux 3.2-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Nov 2011 12:13:16 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Alessandro Suardi <alessandro.suardi@...il.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	platform-driver-x86@...r.kernel.org
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 3.2-rc1

On Tue, Nov 8, 2011 at 6:53 AM, Alessandro Suardi
<alessandro.suardi@...il.com> wrote:
>
> Dell laptop support (and I'd suspect other drivers using LED support)
>  doesn't build with undefined LED-related functions, as in:
>
> ERROR: "led_classdev_unregister" [drivers/platform/x86/dell-laptop.ko]
> undefined!
> ERROR: "led_classdev_register" [drivers/platform/x86/dell-laptop.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> It's enough to configure NEW_LEDS (unneeded in 3.1.0) to allow the build to go
>  through; maybe NEW_LEDS should be auto-selected in Kconfig by drivers that
>  make use of led_classdev_* functions ?

Yeah, that sounds like the right fix. There are a lot of "select
NEW_LEDS" around already, but apparently not the Dell driver.

Matthew?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/