linux-kernel - Re: [PATCH] virtio-pci: fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y5vqrk5s.fsf@rustcorp.com.au>
Date:	Tue, 08 Nov 2011 20:49:27 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Amit Shah <amit.shah@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] virtio-pci: fix use after free

On Tue, 8 Nov 2011 11:16:16 +0530, Amit Shah <amit.shah@...hat.com> wrote:
> On (Mon) 07 Nov 2011 [18:37:05], Michael S. Tsirkin wrote:
> > Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
> > a use after free in virtio-pci. The main issue is
> > that the release method signals removal of the virtio device,
> > while remove signals removal of the pci device.
> > 
> > For example, on driver removal or hot-unplug,
> > virtio_pci_release_dev is called before virtio_pci_remove.
> > We then might get a crash as virtio_pci_remove tries to use the
> > device freed by virtio_pci_release_dev.
> > 
> > We allocate/free all resources together with the
> > pci device, so we can leave the release method empty.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> Acked-by: Amit Shah <amit.shah@...hat.com>
> 
> (note: Adding CC: stable@...nel.org to the commit log is the way
> patches get automatically pulled from upstream when committed; CC'ing
> stable on submissions won't help with that.)

Yeah, I fixed it though.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/