linux-kernel - linux-next: incorrect build fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Nov 2011 08:26:24 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Kyungmin Park <kyungmin.park@...sung.com>
Cc:	Kukjin Kim <kgene.kim@...sung.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: linux-next: incorrect build fix

Hi,

I noticed in commit 8644c202ff42 ("ARM: EXYNOS: Fix compiler error with
THIS_MODULE") in the s5p tree, an include of linux/module.h is used to
get THIS_MODULE. For THIS_MODULE, you only need to include
linux/export.h, now.  To fix the other errors that were fixed by side
effects of including module.h, you should include linux/time.h (for
struct timeval, USEC_PER_SEC and do_gettimeofday).

Please try a bit harder to get these things right.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped