linux-kernel - Re: [PATCH -mm] cgroup: Fix task counter common ancestor logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111108135111.6a74f1d2.akpm@linux-foundation.org>
Date:	Tue, 8 Nov 2011 13:51:11 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ben Blum <bblum@...rew.cmu.edu>,
	Li Zefan <lizf@...fujitsu.com>,
	Paul Menage <paul@...lmenage.org>,
	Tim Hockin <thockin@...kin.org>, Tejun Heo <tj@...nel.org>,
	Containers <containers@...ts.linux-foundation.org>,
	Cgroups <cgroups@...r.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH -mm] cgroup: Fix task counter common ancestor logic

On Tue,  8 Nov 2011 16:21:10 +0100
Frederic Weisbecker <fweisbec@...il.com> wrote:

> To solve this, keep the original cgroup of each thread in the thread
> group cached in the flex array and pass it to can_attach_task()/attach_task()
> and cancel_attach_task() so that the correct common ancestor between the old
> and new cgroup can be safely retrieved for each task.

OK, thanks.

We need to work out what to do with this patchset.  ie: should we merge
it.  I'm not sure that the case has been made?

Let's please drag this thing onto the table and poke at it for a while.
Probably everyone has forgotten everything so we'll need to start
again, sorry.  Perhaps you can (re)start proceedings by telling us why
it's useful to our users and why we should merge it?

Some mental notes:

Tim says it would be useful for the things he's doing but doesn't
appear to have confirmed/tested that.

Kay has said that it would not be useful for his plumber's wishlist
item, which is a shame.

I seem to recall complaining that it doesn't address the forkbomb issue
for non-cgroups setups, so the forkbomb issue remains unaddressed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/