linux-kernel - Re: [PATCH 2/2] mfd: include linux/module.h for ab5500-debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Nov 2011 11:14:15 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	Mattias Wallin <mattias.wallin@...ricsson.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 2/2] mfd: include linux/module.h for ab5500-debugfs

2011/11/8 Axel Lin <axel.lin@...il.com>:
> 2011/11/8 Paul Gortmaker <paul.gortmaker@...driver.com>:
>> On 11-11-06 10:20 PM, Axel Lin wrote:
>>> Include linux/module.h to fix below build error:
>>>
>>>   CC      drivers/mfd/ab5500-debugfs.o
>>> drivers/mfd/ab5500-debugfs.c:571: error: 'THIS_MODULE' undeclared here (not in a function)
>>> make[2]: *** [drivers/mfd/ab5500-debugfs.o] Error 1
>>>
>>> Signed-off-by: Axel Lin <axel.lin@...il.com>
>>> ---
>>>  drivers/mfd/ab5500-debugfs.c |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mfd/ab5500-debugfs.c b/drivers/mfd/ab5500-debugfs.c
>>> index 6be1fe6..b7b2d348 100644
>>> --- a/drivers/mfd/ab5500-debugfs.c
>>> +++ b/drivers/mfd/ab5500-debugfs.c
>>> @@ -4,6 +4,7 @@
>>>   * Debugfs support for the AB5500 MFD driver
>>>   */
>>>
>>> +#include <linux/module.h>
>>
>> This one looks incorrect.  I don't see any uses of MODULE_* or
>> module_* in the file, so I'll make a commit for it to use export.h
>> and retest.
>>
> hi Paul,
> drivers/mfd/ab8500-debugfs.c does use MODULE_AUTHOR, MODULE_DESCRIPTION, etc.
> I got below build error if only includes linux/export.h
>
>  CC      drivers/mfd/ab8500-debugfs.o
Ooops. Sorry, I change wrong file. We are talking about
ab5500-debugfs.c not ab8500-debugfs.c.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/