lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <4EB87636.6030504@huawei.com>
Date:	Tue, 08 Nov 2011 08:22:14 +0800
From:	"canquan.shen" <shencanquan@...wei.com>
To:	Len Brown <lenb@...nel.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"xiaowei.yang@...wei.com" <xiaowei.yang@...wei.com>,
	hanweidong <hanweidong@...wei.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	james.chenjiabo@...wei.com, wuchangyi@...wei.com
Subject: Re: [PATCH v5] acpi: Fix CPU hot removal problem

On 2011/11/8 1:37, Len Brown wrote:
> It doesn't apply for me, and it looks white-space damaged.
> Does it pass checkpatch.pl for you and apply for you?
> Possibly an issue with my new gmail setup,
> but it looks more like this was damaged at the source.
>
>
> ERROR: code indent should use tabs where possible
> #103: FILE: drivers/acpi/processor_driver.c:668:
> +        acpi_bus_hot_remove_device(handle);$
>
> WARNING: please, no spaces at the start of a line
> #103: FILE: drivers/acpi/processor_driver.c:668:
> +        acpi_bus_hot_remove_device(handle);$
>
> WARNING: please, no spaces at the start of a line
> #125: FILE: drivers/acpi/scan.c:132:
> +    if (ACPI_FAILURE(status)&&  (status != AE_NOT_FOUND))$
>
> WARNING: suspect code indent for conditional statements (4, 9)
> #125: FILE: drivers/acpi/scan.c:132:
> +    if (ACPI_FAILURE(status)&&  (status != AE_NOT_FOUND))
>            printk(KERN_WARNING PREFIX
>


Hi Len,
    Because I copy the patch to the email and my git proxy is not ready 
in window.  Please use the attachment to apply. it passed by checkpatch.pl.
    I will install the git in linux server. and later I will use it to 
send the patch.

Thanks,
Canquan.shen



View attachment "0001-acpi-Fix-CPU-hot-removal-problem.patch" of type "text/plain" (2904 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ