linux-kernel - Re: [PATCHv6 01/19] usb: otg: Rename otg_transceiver to usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAe_U6JnWLioK_NCz03uCGd3T0aV56-M3MFgRUdJVX4nB1uhbg@mail.gmail.com>
Date:	Tue, 8 Nov 2011 11:27:12 +0530
From:	"ABRAHAM, KISHON VIJAY" <kishon@...com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Felipe Balbi <balbi@...com>, Greg KH <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCHv6 01/19] usb: otg: Rename otg_transceiver to usb_phy

Hi Heikki,

On Fri, Oct 28, 2011 at 6:05 PM, Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
> This is the first step in separating USB transceivers from
> USB OTG utilities.
>
> Includes fixes to IMX code from Sascha Hauer.

I tend to defer with your opinion of renaming otg_transceiver to
usb_phy. According to me otg_transceiver should program hardware
mechanisms associated to VBUS, ID lines, etc.. and phy is responsible
for transmitting data over differential data lines (with its own
programming of phy_init, phy_shutdown, setting phy clocks etc..). So
in my opinion otg_transceiver and usb_phy should be two different and
separate entities.

I would have preferred to rename otg_transceiver as usb_otg as the
first step. (this differs from your implementation where you rename
otg_transceiver to usb_phy and create a new structure usb_otg to
separate otg members from usb_phy).

But it should have been first  rename otg_transceiver as usb_otg. Then
create a new structure usb_phy to move all the phy specific
implementation there. This kind of implementation will also help when
we want to have independent phy drivers.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/