linux-kernel - Re: [Xen-devel] RE: [PATCH 3/3] code clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320841103.955.120.camel@zakaz.uk.xensource.com>
Date:	Wed, 9 Nov 2011 12:18:23 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Paul Durrant <Paul.Durrant@...rix.com>
CC:	"annie.li@...cle.com" <annie.li@...cle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"kurt.hackel@...cle.com" <kurt.hackel@...cle.com>
Subject: Re: [Xen-devel] RE: [PATCH 3/3] code clean up

On Wed, 2011-11-09 at 11:15 +0000, Paul Durrant wrote:
> Annie,
> 
>   Why was this split out as a separate patch? Can it not be folded into patch 2 since the line it re-formats was introduced there?

It is not generally necessary to split string constants in order to meet
the 80 column (soft) limit in Linux code. Some people frown on it
because it breaks grep'ability.

Ian.

> 
>   Paul
> 
> > -----Original Message-----
> > From: annie.li@...cle.com [mailto:annie.li@...cle.com]
> > Sent: 09 November 2011 08:16
> > To: xen-devel@...ts.xensource.com; linux-kernel@...r.kernel.org;
> > konrad.wilk@...cle.com; jeremy@...p.org
> > Cc: kurt.hackel@...cle.com; Paul Durrant; annie.li@...cle.com
> > Subject: [PATCH 3/3] code clean up
> > 
> > From: Annie Li <annie.li@...cle.com>
> > 
> > Signed-off-by: Annie Li <annie.li@...cle.com>
> > ---
> >  drivers/xen/grant-table.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> > index a3294a26..458c00d 100644
> > --- a/drivers/xen/grant-table.c
> > +++ b/drivers/xen/grant-table.c
> > @@ -708,7 +708,8 @@ static void gnttab_request_version(void)  {
> >  	int rc;
> >  	struct gnttab_set_version gsv;
> > -	const char *str = "we need grant tables version 2, but only
> > version 1 is available\n";
> > +	const char *str = "we need grant tables version 2, "
> > +					"but only version 1 is
> > available\n";
> > 
> >  	gsv.version = 2;
> >  	rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv,
> > 1);
> > --
> > 1.7.6
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xensource.com
> http://lists.xensource.com/xen-devel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/