linux-kernel - Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Nov 2011 18:19:43 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	Nao Nishijima <nao.nishijima.xt@...achi.com>,
	Alan Cox <alan@...ux.intel.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias"
 in gendisk"

On Wed, Nov 9, 2011 at 17:53, Greg KH <gregkh@...e.de> wrote:
> On Wed, Nov 09, 2011 at 08:25:12AM -0800, Tejun Heo wrote:
>> This reverts commit a72c5e5eb738033938ab30d6a634b74d1d060f10.
>>
>> The commit introduced alias for block devices which is intended to be
>> used during logging although actual usage hasn't been committed yet.
>> This approach adds very limited benefit (raw log might be easier to
>> follow) which can be trivially implemented in userland but has a lot
>> of problems.
>>
>> It is much worse than netif renames because it doesn't rename the
>> actual device but just adds conveninence name which isn't used
>> universally or enforced.  Everything internal including device lookup
>> and sysfs still uses the internal name and nothing prevents two
>> devices from using conflicting alias - ie. sda can have sdb as its
>> alias.
>>
>> This has been nacked by people working on device driver core, block
>> layer and kernel-userland interface and shouldn't have been
>> upstreamed.  Revert it.
>>
>>  http://thread.gmane.org/gmane.linux.kernel/1155104
>>  http://thread.gmane.org/gmane.linux.scsi/68632
>>  http://thread.gmane.org/gmane.linux.scsi/69776
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Cc: Jens Axboe <axboe@...nel.dk>
>> Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
>> Cc: Nao Nishijima <nao.nishijima.xt@...achi.com>
>> Cc: Kay Sievers <kay.sievers@...y.org>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>
> Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

 Acked-by: Kay Sievers <kay.sievers@...y.org>

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/