linux-kernel - Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPXgP13x9vvZ3pfW7u=o5rEaTAg_xV7=RC_UFuhk_aRdB4G0vg@mail.gmail.com>
Date:	Wed, 9 Nov 2011 18:38:21 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	Nao Nishijima <nao.nishijima.xt@...achi.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias"
 in gendisk"

On Wed, Nov 9, 2011 at 18:30, James Bottomley
<James.Bottomley@...senpartnership.com> wrote:
> On Wed, 2011-11-09 at 08:25 -0800, Tejun Heo wrote:

> No, I can't agree with this ... if you propose a working alternative,

The solution to this problem is to let udev log the known symlinks to
the log stream at device discovery time. That way you can log _all_
kernel device messages to the currently know disk names. This works
already even on old systems,

> I'm listening, but in the absence of one, I think the hack fills a gap

There is no gap.

> we have in log analysis and tides us over until we have an agreed on
> proper solution (at which point, I'm perfectly happy to pull the hack
> back out).

Log analysis works just fine with the udev solution and provides the
far better solution to this exact problem, so please revert it.

Such hacks are not supposed to get in, and its really hard to get them
out again.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/