linux-kernel - Re: [PATCH 1/4] MIPS Kprobes: Fix OOPS in arch_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111109052607.GA20317@cisco.com>
Date:	Wed, 9 Nov 2011 10:56:07 +0530
From:	Maneesh Soni <manesoni@...co.com>
To:	David Daney <david.daney@...ium.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	"ananth@...ibm.com" <ananth@...ibm.com>,
	"kamensky@...co.com" <kamensky@...co.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>
Subject: Re: [PATCH 1/4] MIPS Kprobes: Fix OOPS in arch_prepare_kprobe()

On Tue, Nov 08, 2011 at 11:57:45AM -0800, David Daney wrote:
> On 11/08/2011 09:04 AM, Maneesh Soni wrote:
> [...]
> >
> >diff --git a/arch/mips/kernel/kprobes.c b/arch/mips/kernel/kprobes.c
> >index ee28683..9fb1876 100644
> >--- a/arch/mips/kernel/kprobes.c
> >+++ b/arch/mips/kernel/kprobes.c
> >@@ -25,6 +25,7 @@
> >
> >  #include<linux/kprobes.h>
> >  #include<linux/preempt.h>
> >+#include<linux/uaccess.h>
> >  #include<linux/kdebug.h>
> >  #include<linux/slab.h>
> >
> >@@ -118,11 +119,19 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
> >  	union mips_instruction prev_insn;
> >  	int ret = 0;
> >
> >-	prev_insn = p->addr[-1];
> >  	insn = p->addr[0];
> >
> >-	if (insn_has_delayslot(insn) || insn_has_delayslot(prev_insn)) {
> >-		pr_notice("Kprobes for branch and jump instructions are not supported\n");
> >+	if (insn_has_delayslot(insn)) {
> >+		pr_notice("Kprobes for branch and jump instructions are not"
> >+			  "supported\n");
> 
> Don't wrap these strings.
> 
> It is better to go a little bit over 80 columns, than have this.
> 
> David Daney

Ok.. will keep that in mind for future patches. This line actually
goes away in patch 4/4.

Thanks
Maneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/