linux-kernel - Re: [PATCH 2/2] USB-renesas: move to dma_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Nov 2011 08:10:24 +0200
From:	Felipe Balbi <balbi@...com>
To:	Vinod Koul <vinod.koul@...ux.intel.com>
Cc:	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	jaswinder.singh@...aro.org, 21cnbao@...il.com,
	rmk@....linux.org.uk, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH 2/2] USB-renesas: move to dma_transfer_direction

Hi,

On Fri, Oct 14, 2011 at 10:09:10PM +0530, Vinod Koul wrote:
> fixup usage of dma direction by introducing dma_transfer_direction,
> this patch moves usb/renesas driver to use new enum
> 
> Signed-off-by: Vinod Koul <vinod.koul@...ux.intel.com>
> Cc: Felipe Balbi <balbi@...com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>

This looks ok too:

Acked-by: Felipe Balbi <balbi@...com>

Kuninori-san, please have a look and reply with your Acked-by if you
think it's ok.

> ---
> v2: split the usb patch into two patches
> 
>  drivers/usb/renesas_usbhs/fifo.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
> index a34430f..f5bc370 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -591,10 +591,10 @@ static void usbhsf_dma_prepare_tasklet(unsigned long data)
>  	struct dma_async_tx_descriptor *desc;
>  	struct dma_chan *chan = usbhsf_dma_chan_get(fifo, pkt);
>  	struct device *dev = usbhs_priv_to_dev(priv);
> -	enum dma_data_direction dir;
> +	enum dma_transfer_direction dir;
>  	dma_cookie_t cookie;
>  
> -	dir = usbhs_pipe_is_dir_in(pipe) ? DMA_FROM_DEVICE : DMA_TO_DEVICE;
> +	dir = usbhs_pipe_is_dir_in(pipe) ? DEV_TO_MEM : MEM_TO_DEV;
>  
>  	sg_init_table(&sg, 1);
>  	sg_set_page(&sg, virt_to_page(pkt->dma),
> -- 
> 1.7.0.4
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)