linux-kernel - Re: [PATCH] nilfs2: unbreak compat ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111110.124918.255392182.ryusuke@osrg.net>
Date:	Thu, 10 Nov 2011 12:49:18 +0900 (JST)
From:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
To:	thomas@...3r.de
Cc:	linux-kernel@...r.kernel.org, linux-nilfs@...r.kernel.org
Subject: Re: [PATCH] nilfs2: unbreak compat ioctl

On Mon, 07 Nov 2011 21:18:37 +0100, Thomas Meyer wrote:
> I guess commit 828b1c50ae11e6dda68f8dfefe43b74c7182b157 incidentally broke
> all other compat ioctls. make them work again.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
>  fs/nilfs2/ioctl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index 41d6743..1773a98 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -842,8 +842,6 @@ long nilfs_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	case FS_IOC32_GETVERSION:
>  		cmd = FS_IOC_GETVERSION;
>  		break;
> -	default:
> -		return -ENOIOCTLCMD;
>  	}
>  	return nilfs_ioctl(filp, cmd, (unsigned long)compat_ptr(arg));
>  }
> -- 
> 1.7.7

Hi, thank you for pointing this out.

But, this patch looks to prevent compat_sys_ioctl() from handling
other compatible ioctls that compat_ioctl_check_table function
detects.  For instance, fiemap (FS_IOC_FIEMAP) is handled via the
function.

I think we should only redirect own ioctl commands
(i.e. NILFS_IOCTL_xxxx) to the nilfs_ioctl() call.


Regards,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/