linux-kernel - Re: [PATCH 1/6] user namespace: make signal.c respect user namespaces (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111110014114.GB26567@count0.beaverton.ibm.com>
Date:	Wed, 9 Nov 2011 17:41:14 -0800
From:	Matt Helsley <matthltc@...ibm.com>
To:	"Serge E. Hallyn" <serge.hallyn@...onical.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, richard@....at,
	containers@...ts.linux-foundation.org, oleg@...hat.com,
	eparis@...hat.com, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, ebiederm@...ssion.com
Subject: Re: [PATCH 1/6] user namespace: make signal.c respect user
 namespaces (v4)

On Wed, Nov 09, 2011 at 08:18:53AM -0600, Serge E. Hallyn wrote:
> Quoting Andrew Morton (akpm@...ux-foundation.org):
> > On Fri,  4 Nov 2011 22:24:37 +0000
> > Serge Hallyn <serge@...lyn.com> wrote:
> > 
> > > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t)

nit: Seems like the function name itself needs a fixup. I can imagine a
user-ns-unaware kernel developer thinking this when they see code calling
this function:

<naive>
Gosh, why is the uid broken? I have no idea what this does or when it
would be needed. Why hasn't it been splatted all over the kernel? Who broke
it?
</naive>

You can't even tell from the name that it's for user namespaces.

Cheers,
	-Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/