linux-kernel - Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EBB2F68.8070609@oracle.com>
Date:	Thu, 10 Nov 2011 09:56:56 +0800
From:	ANNIE LI <annie.li@...cle.com>
To:	Ian Campbell <Ian.Campbell@...rix.com>
CC:	"jeremy@...p.org" <jeremy@...p.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"kurt.hackel@...cle.com" <kurt.hackel@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Paul Durrant <Paul.Durrant@...rix.com>
Subject: Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture



On 2011-11-10 0:22, Ian Campbell wrote:
> IMHO the gnttab_ bit belongs in either (or both) the struct name or the
> variable names referencing the struct, rather than the fields
> themselves. It should be obvious from the context that this member is
> something to do with gnttab. e.g. I think gnttab_shared->addr would be
> fine, as would shared->addr in the context of gnttab.c etc.
Right.
Thanks you all for the review, I will improve patches based on those 
suggestions and resend them.

Thanks
Annie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/