linux-kernel - Re: [MAILER-DAEMON@...l.linuxfoundation.org: Undelivered Mail Returned to Sender]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111110143243.GB7727@sergelap>
Date:	Thu, 10 Nov 2011 08:32:43 -0600
From:	"Serge E. Hallyn" <serge.hallyn@...onical.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, serge@...lyn.com, oleg@...hat.com
Subject: Re: [MAILER-DAEMON@...l.linuxfoundation.org: Undelivered Mail
 Returned to Sender]

...
> > Would you prefer something like:
> >
> > +#ifdef CONFIG_USER_NS
> > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t)
> > +{
> > +       if (current_user_ns() == task_cred_xxx(t, user_ns))
> > +               return;
> > +
> > +       if (SI_FROMKERNEL(info))
> > +               return;
> > +
> > +       info->si_uid = user_ns_map_uid(task_cred_xxx(t, user_ns),
> > +                                       current_cred(), info->si_uid);
> > +}
> > +#else
> > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t)
> > +{
> > +               return;
> > +}
> > +#endif
> >
> > ?  It's less sneaky at least.
> 
> Very much.  The current version looks like a bug.

Thanks, I'll switch to that and hopefully resend the set soon.

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/