Message-ID: <CANEJEGuS1w_rPsjOfY8TqP=TewjRLSdEeR+OmaGB3G4LQZg82Q@mail.gmail.com>
Date:	Thu, 10 Nov 2011 08:54:31 -0800
From:	Grant Grundler <grundler@...gle.com>
To:	Mark Lord <kernel@...savvy.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ben Hutchings <bhutchings@...arflare.com>,
	Michal Marek <mmarek@...e.cz>, Freddy Xin <freddy@...x.com.tw>,
	"ASIX Allan Email [office]" <allan@...x.com.tw>
Subject: Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy

+ASIX (Freddy Xin and Allan)

On Thu, Nov 10, 2011 at 6:01 AM, Mark Lord <kernel@...savvy.com> wrote:
> On 11-11-09 12:31 PM, Mark Lord wrote:
>> Second pass (for review) at updating the in-kernel asix usb/network driver
>> from the v4.1.0 vendor GPL version of the driver, obtained from here:
>>
>>   http://www.asix.com.tw/download.php?sub=searchresult&PItemID=84&download=driver
>>
>> The original vendor copy used a local "axusbnet" middleware (rather than "usbnet").
>> I've converted it back to using "usbnet", made a ton of cosmetic changes
>> to get it to pass checkpatch.pl, and removed a small amount of code duplication.
>>
>> The tx/rx checksum code has been updated per Ben's comments,
>> and the duplicated MII_* definitions have been removed.
>> I've changed the version string to be "4.1.0-kernel",
>> to reflect the vendor's code version while also distinguishing
>> this port from the original vendor code.
>>
>> It can use more work going forward, but it is important to get it upstream
>> sooner than later -- the current in-kernel driver fails with many devices,
>> both old and new.  This updated version works with everything I have available
>> to test with, and also handles suspend / resume (unlike the in-kernel one).
>>
>> Signed-off-by: Mark Lord <mlord@...ox.com>
> ...
>
> Okay, the vendor has told me to cease development on this now.
> They prefer instead to feed small parts of their mainline driver
> to Grant Grundler as issues arise, rather than to get the whole
> thing upstream.

Hi Mark,
I'm very surprise a second time now. It's partly my own fault since
I'm not following netdev.  Until you contacted me privately 8 days
ago, I didn't know that you had been working with ASIX on asix.c. That
was the first surprise.

The second surprise is ASIX suggested I'm going to be the conduit for
all their patches upstream. I never committed to that.  I was very
clear that I would help them get started by feeding 3 small patches to
"upstream". I've fulfilled that commitment (3 fixes plus one cleanup).
  I have one more patch (work in progress:
https://gerrit.chromium.org/gerrit/11485 ) I'd like to see go in and
then they have to start "catching their own fish".

The statement above implies Google has an economic interest in their
products and AFAIK that's not true. We do not buy their product in
volume. Getting this working has sort of been my 20% project over the
past couple of months. It would have been cheaper buy USB ethernet
dongles from a vendor with working Linux support and *give* them to
our partners who need them.

Lastly, offlist I have expressed my opinion about 5K line patches to
you and to ASIX.  I'm not allowed to push such large patches into
Chromium.org (upstream first!) and I was certain on their own, ASIX
wouldn't get that upstream in one shot. No one knows them. No one
trusts them. Asix never mentioned that they had already hired you to
do it (and I am pretty sure you could have). So I feel a bit blind
sided (as you probably do to) by how events are unfolding here. ASIX
may still need help to *continue* upstreaming additional functionality
(e.g. CSO/TSO) and I will remind ASIX of that in future
communications.

*sigh*

cheers,
grant


> So be it.
>
> Cheers
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists