linux-kernel - Re: [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting IIO channels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EBC0418.2040005@cam.ac.uk>
Date:	Thu, 10 Nov 2011 17:04:24 +0000
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, guenter.roeck@...csson.com,
	khali@...ux-fr.org, dmitry.torokhov@...il.com, gregkh@...e.de,
	alan@...rguk.ukuu.org.uk, arnd@...db.de, linus.walleij@...aro.org,
	lars@...afoo.de, maxime.ripard@...e-electrons.com,
	lm-sensors@...sensors.org, thomas.petazzoni@...e-electrons.com,
	zdevai@...il.com
Subject: Re: [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting
 IIO channels.

On 11/10/2011 01:25 PM, Mark Brown wrote:
> On Mon, Nov 07, 2011 at 03:44:39PM +0000, Jonathan Cameron wrote:
>> From: Jonathan Cameron <jic23@....ac.uk>
>>
>> Two elements here:
>> * Map as defined in include/linux/iio/inkern.h
>> * Matching code to actually get the iio_dev and channel
>> that we want from the global list of IIO devices.
> 
> I've not read it thoroughly but this certainly this looks sensible from
> an external interface point of view, I'd expect that issues can be
> worked through incrementally.
> 
> Reviewed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Thanks.
> 
>> +extern struct list_head iio_map_list;
> 
> It's surprising that this is part of the external interface of IIO
> rather than something hidden within the implementation.
You are quite correct. I was being lazy and had that one element that
didn't fit in any headers.  I'lll add a trivial inkern-core.h to handle
that one bit.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/