linux-kernel - Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 13:52:33 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and
 !intel-iommu

On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> +#define intel_iommu_gfx_mapped 1 

That ought to be zero; if the IOMMU code isn't present, it's
*definitely* not mapped through the IOMMU :)

But I'm fairly sure this was already noticed and a patch is on its way
upstream already.

It's my fault — my original testing patches to expose this information
from the IOMMU code did put it into a header file, but when I sent it
upstream I missed that part of the patch, thus leading to the horrid
'extern int intel_iommu_gfx_mapped;' in intel-gtt.c that your patch
removes.

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5818 bytes)