[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2011 14:57:20 +1030
From: Rusty Russell <rusty@...tcorp.com.au>
To: Miche Baker-Harvey <miche@...gle.com>,
Greg Kroah-Hartman <gregkh@...e.de>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
xen-devel@...ts.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org,
Anton Blanchard <anton@...ba.org>,
Amit Shah <amit.shah@...hat.com>,
Mike Waychison <mikew@...gle.com>,
ppc-dev <linuxppc-dev@...ts.ozlabs.org>,
Eric Northrup <digitaleric@...gle.com>
Subject: Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.
On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey <miche@...gle.com> wrote:
> Some modifications of vtermno were not done under the spinlock.
>
> Moved assignment from vtermno and increment of vtermno together,
> putting both under the spinlock. Revert vtermno on failure.
>
> Signed-off-by: Miche Baker-Harvey <miche@...gle.com>
Does it matter? It's normal not to lock in a function called
"init_XXX", since it's not exposed yet.
Or is it?
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists