linux-kernel - Re: [PATCH 0/2] mfd/stmpe: Add SPI interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 15:13:46 +0530
From:	Rabin Vincent <rabin@....in>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	linus.walleij@...ricsson.com, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com, armando.visconti@...com,
	shiraz.hashim@...com, vipin.kumar@...com, rajeev-dlh.kumar@...com,
	deepak.sikri@...com, vipulkumar.samar@...com, amit.virdi@...com,
	pratyush.anand@...com, bhupesh.sharma@...com,
	viresh.linux@...il.com, bhavna.yadav@...com,
	vincenzo.frascino@...com, mirko.gardi@...com,
	srinidhi.kasagar@...ricsson.com
Subject: Re: [PATCH 0/2] mfd/stmpe: Add SPI interface support

On Tue, Nov 8, 2011 at 12:35, Viresh Kumar <viresh.kumar@...com> wrote:
> Few STMPE controller can have register interface over SPI or I2C. Current
> implementation only supports I2C and all code is present in a single file
> stmpe.c.
>
> This patchset separates out code into three files
> - stmpe: specific to controller only
> - stmpe-i2c: specific to i2c interface
> - stmpe-spi: specific to spi interface
>
> In order to rebase it cleanly, please apply earlier floated patch
>        "mfd/stmpe: Add support for irq over gpio pin"
>
> Viresh Kumar (2):
>  mfd/stmpe: separate out controller and interface specific code
>  mfd/stmpe: Add support for SPI interface

Could you instead convert stmpe to use the register map API, and then
add the SPI interface?  Converting to regmap should both simplify the
existing code as well as make it possible to add the second interface
with fewer lines of code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/