linux-kernel - Re: [bisected][bug] commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201111122325.09134.rjw@sisk.pl>
Date:	Sat, 12 Nov 2011 23:25:08 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [bisected][bug] commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.

On Saturday, November 12, 2011, Arnd Bergmann wrote:
> On Saturday, November 12, 2011, Rafael J. Wysocki wrote:
> > If that's "acpi_idle", the appended patch should help (it works for
> > me at least).
> 
> Hi Rafael,
> 
> I currently have limited email connectivity but I happened to bisect the
> same bug and your patch fixes it for me. I am certainly on acpi_idle
> with my thinkpad w500.

Yes, I'm quite sure everyone on acpi_idle is affected by this bug.

> Sorry for breaking the email threading and dropping people from Cc.

No problem.

> > From: Rafael J. Wysocki <rjw@...k.pl>
> > Subject: ACPI / cpuidle: Remove acpi_idle_suspend (to fix suspend regression)
> > After commit e978aa7d7d57d04eb5f88a7507c4fb98577def77 (cpuidle: Move
> > dev->last_residency update to driver enter routine; remove
> > dev->last_state) setting acpi_idle_suspend to 1 by
> > acpi_processor_suspend() causes the ACPI cpuidle routines to return
> > error codes continuously, which in turn causes cpuidle to lock up
> > (hard).  However, acpi_idle_suspend doesn't appear to be useful for
> > any purpose (it's racy and doesn't really provide any real
> > protection), so it can be removed, which makes the problem go away.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> 
> Tested-by: Arnd Bergmann <arnd@...db.de>

Thanks for the info.  Unfortunately, I've already resent the patch without
your Tested-by: tag, but it can still be added when the patch is committed.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/