| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Nov 2011 21:26:29 -0800
From: "Fenghua Yu" <fenghua.yu@...el.com>
To: "Thomas Gleixner" <tglx@...utronix.de>,
"H Peter Anvin" <hpa@...or.com>, "Ingo Molnar" <mingo@...e.hu>,
"Linus Torvalds" <torvalds@...ux-foundation.org>,
"Andrew Morton" <akpm@...ux-foundation.org>,
"Tony Luck" <tony.luck@...el.com>,
"Arjan van de Ven" <arjan.van.de.ven@...el.com>,
"Suresh B Siddha" <suresh.b.siddha@...el.com>,
"Len Brown" <len.brown@...el.com>,
"Randy Dunlap" <rdunlap@...otime.net>,
"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Peter Zijlstra <peterz@...radead.org>
Cc: "linux-kernel" <linux-kernel@...r.kernel.org>,
"linux-pm" <linux-pm@...r.kernel.org>, "x86" <x86@...nel.org>,
"Fenghua Yu" <fenghua.yu@...el.com>
Subject: [PATCH v4 4/7] x86/smpboot.c: Don't offline BSP if any irq can not be migrated out of it
From: Fenghua Yu <fenghua.yu@...el.com>
Don't offline BSP if any irq can not be migrated out of it.
Call identify_boot_cpu_online() for BSP in smp_callin() and continue to online
BSP in native_cpu_up().
Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
---
arch/x86/kernel/smpboot.c | 43 ++++++++++++++++++++++++++++++++++++-------
1 files changed, 36 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 9f548cb..83838c5 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -136,8 +136,8 @@ EXPORT_PER_CPU_SYMBOL(cpu_info);
atomic_t init_deasserted;
/*
- * Report back to the Boot Processor.
- * Running on AP.
+ * Report back to the Boot Processor during boot time or to the caller processor
+ * during CPU online.
*/
static void __cpuinit smp_callin(void)
{
@@ -224,6 +224,13 @@ static void __cpuinit smp_callin(void)
smp_store_cpu_info(cpuid);
/*
+ * This function won't run on the BSP during boot time. It run
+ * on BSP only when BSP is offlined and onlined again.
+ */
+ if (cpuid == 0)
+ identify_boot_cpu_online();
+
+ /*
* This must be done before setting cpu_online_mask
* or calling notify_cpu_starting.
*/
@@ -839,7 +846,7 @@ int __cpuinit native_cpu_up(unsigned int cpu)
pr_debug("++++++++++++++++++++=_---CPU UP %u\n", cpu);
- if (apicid == BAD_APICID || apicid == boot_cpu_physical_apicid ||
+ if (apicid == BAD_APICID ||
!physid_isset(apicid, phys_cpu_present_map)) {
printk(KERN_ERR "%s: bad cpu %d\n", __func__, cpu);
return -EINVAL;
@@ -1283,12 +1290,34 @@ int native_cpu_disable(void)
* Perhaps use cpufreq to drop frequency, but that could go
* into generic code.
*
- * We won't take down the boot processor on i386 due to some
+ * We won't take down the boot processor on i386 if some
* interrupts only being able to be serviced by the BSP.
- * Especially so if we're not using an IOAPIC -zwane
+ * Especially so if we're not using an IOAPIC
+ * -original comment from zwane, changed by fyu
*/
- if (cpu == 0)
- return -EBUSY;
+ if (cpu == 0) {
+ int irq;
+ struct irq_desc *desc;
+ struct irq_data *data;
+ struct irq_chip *chip;
+
+ for_each_irq_desc(irq, desc) {
+ raw_spin_lock(&desc->lock);
+ if (!irq_has_action(irq)) {
+ raw_spin_unlock(&desc->lock);
+ continue;
+ }
+
+ data = irq_desc_get_irq_data(desc);
+ chip = irq_data_get_irq_chip(data);
+ if (!chip->irq_set_affinity) {
+ pr_debug("irq%d can't move out of BSP\n", irq);
+ raw_spin_unlock(&desc->lock);
+ return -EBUSY;
+ }
+ raw_spin_unlock(&desc->lock);
+ }
+ }
clear_local_APIC();
--
1.6.0.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists