linux-kernel - Re: [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EBFC148.7070409@cam.ac.uk>
Date:	Sun, 13 Nov 2011 13:08:24 +0000
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY_EVGEN"

On 11/13/2011 01:05 PM, Paul Bolle wrote:
> Commit e6477000fc ("staging:iio:dummy Add event support + fake event
> generator") added "select IIO_SIMPLE_DUMMY_EVGEN if [...]". But there
> is no Kconfig symbol named IIO_SIMPLE_DUMMY_EVGEN. The select statement
> for that symbol is a nop. Drop it.
Yes, you are quite right.  Looks like some dead logic from an earlier
version.  My mistake.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
Acked-by: Jonathan Cameron <jic23@...d.ac.uk>
> ---
> 0) Tested with "make menuconfig" before and after applying this patch.
> Identical .config files were generated, as was expected.
> 
> 1) The "select IIO_DUMMY_EVGEN" of the IIO_SIMPLE_DUMMY_EVENTS Kconfig
> entry probably does what was intended here. Maybe that's why no one
> noticed.
Indeed it does.
> 
>  drivers/staging/iio/Kconfig |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index 4ec9118..90162aa 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -76,7 +76,6 @@ config IIO_DUMMY_EVGEN
>  
>  config IIO_SIMPLE_DUMMY
>         tristate "An example driver with no hardware requirements"
> -       select IIO_SIMPLE_DUMMY_EVGEN if IIO_SIMPLE_DUMMY_EVENTS
>         help
>  	 Driver intended mainly as documentation for how to write
>  	 a driver. May also be useful for testing userspace code

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/