linux-kernel - Re: [PATCH v3 2/2] TTY: tty flip buffer optimisation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111114160814.2f9de9a9@lxorguk.ukuu.org.uk>
Date:	Mon, 14 Nov 2011 16:08:14 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Ilya Zykov <ilya@...x.ru>
Cc:	Jiri Slaby <jslaby@...e.cz>, Alan Cox <alan@...ux.intel.com>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [PATCH v3 2/2] TTY: tty flip buffer optimisation.

> For avoid complexity we need remove free buffer at all.
> And use kmalloc()-kfree() for every chunk. Don't need tty_buffer_find().
> It will be fast and easy.

The buffer cycling was added because it speeds up some cases (as you
found), and because its needed for high speed serial on some very low end
devices. From your benchmarks it's also speeding up pty/tty so it's
clearly relevant.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/