linux-kernel - Re: [PATCH] TTY: tty flip buffer with synchronous line disciplines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111114174916.648c2952@lxorguk.ukuu.org.uk>
Date:	Mon, 14 Nov 2011 17:49:16 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Ilya Zykov <ilya@...x.ru>
Cc:	Alan Cox <alan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] TTY: tty flip buffer with synchronous line disciplines.

On Mon, 14 Nov 2011 21:41:36 +0400
Ilya Zykov <ilya@...x.ru> wrote:

> For use flip buffer with synchronous line disciplines(n_hdlc, ppp_synctty).

If you are doing synchronous protocols then they shouldn't be going via
the tty loopback in the first place. Why can't you use tuntap and the
like for synchronous protocols ? Stuffing them through the tty layer is a
bad hack anyway and not one we should encourage further.

> +	if ((b = tty->buf.tail) != NULL  && !tty->pty_sync)
>  		left = b->size - b->used;

What stops tty->pty_sync changing under the line discipline btw ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/