linux-kernel - Re: [PATCH] net/packet: remove dead code and unneeded variable from prb_setup_retire_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111114.000930.2208688710577745372.davem@davemloft.net>
Date:	Mon, 14 Nov 2011 00:09:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jj@...osbits.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	eric.dumazet@...il.com, xiaosuo@...il.com, greearb@...delatech.com,
	loke.chetan@...il.com, waltje@...lt.NL.Mugnet.ORG,
	gw4pts@...pts.ampr.org, waltje@...ux.com, ross.biro@...il.com,
	alan@...ux.intel.com
Subject: Re: [PATCH] net/packet: remove dead code and unneeded variable
 from prb_setup_retire_blk_timer()

From: Jesper Juhl <jj@...osbits.net>
Date: Sun, 13 Nov 2011 22:55:50 +0100 (CET)

> We test for 'tx_ring' being != zero and BUG() if that's the case. So after
> that check there is no way that 'tx_ring' could be anything _but_ zero, so
> testing it again is just dead code. Once that dead code is removed, the
> 'pkc' local variable becomes entirely redundant, so remove that as well.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Applied, thanks Jesper.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/