linux-kernel - RE: [PATCH] ARM: SAMSUNG: gpio-cfg.h: include linux/types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Nov 2011 16:20:37 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Axel Lin' <axel.lin@...il.com>, linux-kernel@...r.kernel.org
Cc:	'Ben Dooks' <ben-linux@...ff.org>,
	'Russell King' <linux@....linux.org.uk>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Marek Szyprowski' <m.szyprowski@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: RE: [PATCH] ARM: SAMSUNG: gpio-cfg.h: include linux/types.h

Axel Lin wrote:
> 
> Include linux/types.h to fix below build error:
> 
>   CC      drivers/power/max8903_charger.o
> In file included from arch/arm/plat-samsung/include/plat/gpio-fns.h:27,
>                  from arch/arm/mach-s3c2410/include/mach/gpio-fns.h:1,
>                  from arch/arm/mach-s3c2410/include/mach/gpio.h:27,
>                  from /home/axel/repos/git/linux-
> 2.6/arch/arm/include/asm/gpio.h:5,
>                  from include/linux/gpio.h:30,
>                  from drivers/power/max8903_charger.c:23:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:27: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:28: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's5p_gpio_drvstr_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:55: error: expected specifier-
> qualifier-list before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:146: error: expected declaration
> specifiers or '...' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:154: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's3c_gpio_getpull'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:173: error: expected declaration
> specifiers or '...' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: In function
> 's3c_gpio_cfgrange_nopull':
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: '__force' undeclared (first
> use in this function)
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: (Each undeclared
> identifier is reported only once
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: for each function it
> appears in.)
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: expected ')' before
> 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: expected ')' before
> numeric constant
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: too many arguments to
> function 's3c_gpio_cfgall_range'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: At top level:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:197: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's5p_gpio_get_drvstr'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:208: error: expected declaration
> specifiers or '...' before 's5p_gpio_drvstr_t'
> make[2]: *** [drivers/power/max8903_charger.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  arch/arm/plat-samsung/include/plat/gpio-cfg.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg.h b/arch/arm/plat-
> samsung/include/plat/gpio-cfg.h
> index d48245b..df8155b 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-cfg.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg.h
> @@ -24,6 +24,8 @@
>  #ifndef __PLAT_GPIO_CFG_H
>  #define __PLAT_GPIO_CFG_H __FILE__
> 
> +#include<linux/types.h>
> +
>  typedef unsigned int __bitwise__ samsung_gpio_pull_t;
>  typedef unsigned int __bitwise__ s5p_gpio_drvstr_t;
> 
> --
> 1.7.5.4
> 

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/