linux-kernel - Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to support S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111115140346.GC26378@amit-x200.redhat.com>
Date:	Tue, 15 Nov 2011 19:33:46 +0530
From:	Amit Shah <amit.shah@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Virtualization List <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to
 support S4

On (Tue) 15 Nov 2011 [14:51:27], Michael S. Tsirkin wrote:
> On Tue, Nov 15, 2011 at 05:59:36PM +0530, Amit Shah wrote:
> > On (Sun) 02 Oct 2011 [11:33:26], Michael S. Tsirkin wrote:
> > > On Thu, Sep 29, 2011 at 09:19:40PM +0530, Amit Shah wrote:
> > > > Remove all the vqs on hibernation and re-create them after restoring
> > > > from a hibernated image.  This keeps networking working across
> > > > hibernation.
> > > > 
> > > > Signed-off-by: Amit Shah <amit.shah@...hat.com>
> > > > ---
> > > >  drivers/net/virtio_net.c |   28 ++++++++++++++++++++++++++++
> > > >  1 files changed, 28 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > index dcd4b01..8b9ed43 100644
> > > > --- a/drivers/net/virtio_net.c
> > > > +++ b/drivers/net/virtio_net.c
> > > > @@ -1131,6 +1131,30 @@ static void __devexit virtnet_remove(struct virtio_device *vdev)
> > > >  	free_netdev(vi->dev);
> > > >  }
> > > >  
> > > > +#ifdef CONFIG_PM
> > > > +static int virtnet_freeze(struct virtio_device *vdev)
> > > > +{
> > > > +	struct virtnet_info *vi = vdev->priv;
> > > 
> > > I'm guessing we need to do something like netif_device_detach here,
> > > otherwise guest might be in the process of using the vq for transmit at
> > > this point.
> > 
> > Done.
> > 
> > > I think we also must make sure NAPI RX handler is not in progress.
> > 
> > How to do that?  napi_disable() / napi_enable() doesn't seem right
> > (and it doesn't work, too).  pci_disable_device() in the suspend
> > routine may work?
> > 
> > > We also might need to mask interrupts from the device
> > > to prevent TX or RX from getting rescheduled?
> > 
> > pci_disable_device() will help this too, right?
> > 
> > 		Amit
> 
> No, why would it help?

IRQs will be disabled after the call to pci_disable_device(), isn't
that sufficient?

		Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/