linux-kernel - Re: [PATCH] serial/8250_pci: add a quirk for the kt serial controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111115191837.GA27512@kroah.com>
Date:	Tue, 15 Nov 2011 11:18:37 -0800
From:	Greg KH <greg@...ah.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	gregkh@...e.de, Nhan H Mai <nhan.h.mai@...el.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	alan@...ux.intel.com
Subject: Re: [PATCH] serial/8250_pci: add a quirk for the kt serial controller

On Tue, Oct 25, 2011 at 01:16:34PM -0700, Dan Williams wrote:
> From: Dan Williams <dan.j.williams@...el.com>
> Date: Sun, 23 Oct 2011 15:06:24 -0700
> Subject: [PATCH v2] serial/8250_pci: add a quirk for the kt serial controller
> 
> Workaround dropped notifications in the iir register.  Prevent reads
> coincident with new interrupt notifications by reading the iir at most
> once per interrupt.
> 
> Reported-by: Nhan H Mai <nhan.h.mai@...el.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> Cc: stable <stable@...r.kernel.org>
> ---
> On Tue, 2011-10-25 at 04:28 +0200, Greg KH wrote:
> On Sun, Oct 23, 2011 at 03:27:16PM -0700, Dan Williams wrote:
> > > --- a/include/linux/pci_ids.h
> > > +++ b/include/linux/pci_ids.h
> [..]
> > Based on the comment at the top of this file, you shouldn't add this
> > entry to it.
> > 
> > Care to redo the patch without that change?
> 
> Ok, moved it to drivers/tty/serial/8250_pci.c and cleaned up the
> conflicting "/* This should be in linux/pci_ids.h */" comment.

This doesn't apply to the 3.2-rc1 kernel at all:

patching file drivers/tty/serial/8250.c
Hunk #1 FAILED at 1652.
1 out of 1 hunk FAILED -- saving rejects to file drivers/tty/serial/8250.c.rej
patching file drivers/tty/serial/8250_pci.c
Hunk #2 succeeded at 1118 with fuzz 1 (offset 9 lines).
Hunk #3 succeeded at 1143 (offset 9 lines).
Hunk #4 succeeded at 1228 (offset 9 lines).
patching file include/linux/serial_core.h
Hunk #1 FAILED at 350.
1 out of 1 hunk FAILED -- saving rejects to file include/linux/serial_core.h.rej
patching file drivers/tty/serial/8250.c
Hunk #1 FAILED at 1652.
1 out of 1 hunk FAILED -- saving rejects to file drivers/tty/serial/8250.c.rej
patching file drivers/tty/serial/8250_pci.c
Hunk #2 succeeded at 1118 with fuzz 1 (offset 9 lines).
Hunk #3 succeeded at 1143 (offset 9 lines).
Hunk #4 succeeded at 1228 (offset 9 lines).
patching file include/linux/serial_core.h
Hunk #1 FAILED at 350.
1 out of 1 hunk FAILED -- saving rejects to file include/linux/serial_core.h.rej

Care to fix it up and resend it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/