linux-kernel - Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Nov 2011 21:17:14 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	Fenghua Yu <fenghua.yu@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-pm" <linux-pm@...r.kernel.org>,
	"linux-next" <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()

On Tuesday, November 15, 2011, Srivatsa S. Bhat wrote:
> On 11/15/2011 05:27 AM, Fenghua Yu wrote:
> > From: Fenghua Yu <fenghua.yu@...el.com>
> > 
> > Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
> > because they are only called during boot time.
> > 
> > Add static for function cpu_hotplug_pm_sync_init() because its scope is limited
> > in this file only.
> > 
> > Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> 
> Acked-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

Well, I guess I can take this one, right?  Any objections from anyone?

Rafael


> > ---
> > v2: Change a function name typo in the title.
> > 
> >  kernel/cpu.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > index 563f136..cf915b8 100644
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -470,7 +470,7 @@ out:
> >  	cpu_maps_update_done();
> >  }
> > 
> > -static int alloc_frozen_cpus(void)
> > +static int __init alloc_frozen_cpus(void)
> >  {
> >  	if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO))
> >  		return -ENOMEM;
> > @@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb,
> >  }
> > 
> > 
> > -int cpu_hotplug_pm_sync_init(void)
> > +static int __init cpu_hotplug_pm_sync_init(void)
> >  {
> >  	pm_notifier(cpu_hotplug_pm_callback, 0);
> >  	return 0;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/