linux-kernel - Re: [PATCH 1/3] tty: make several fops functions non-static so that the pty code can use them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111115202147.GA25654@kroah.com>
Date:	Tue, 15 Nov 2011 12:21:47 -0800
From:	Greg KH <greg@...ah.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] tty: make several fops functions non-static so that
 the pty code can use them

On Sun, Oct 30, 2011 at 09:40:38AM -0700, Arjan van de Ven wrote:
> From: Arjan van de Ven <arjan@...ux.intel.com>
> 
> The pty code currently does a partial function-pointer copy to fill its
> struct file_operations; this patch makes the functions it copies non-static
> in preparation of switching the pty code over to using proper prototypes.
> 
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>

With this patch, I get the following build error:

drivers/tty/tty_io.c:2712:13: error: static declaration of ‘tty_compat_ioctl’ follows non-static declaration
include/linux/tty.h:492:13: note: previous declaration of ‘tty_compat_ioctl’ was here
drivers/tty/tty_io.c:2712:13: warning: ‘tty_compat_ioctl’ defined but not used

Please fix up the series and resend them, in a format that I can apply
them in, without having to edit the body of the patch by hand.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/