linux-kernel - Re: [PATCH pm 1/2] usb_storage: don't use set_freezable_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201111152134.50007.rjw@sisk.pl>
Date:	Tue, 15 Nov 2011 21:34:49 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Greg KH <greg@...ah.com>
Cc:	Tejun Heo <tj@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Seth Forshee <seth.forshee@...onical.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	"Greg Kroah-Hartman" <gregkh@...e.de>
Subject: Re: [PATCH pm 1/2] usb_storage: don't use set_freezable_with_signal()

On Tuesday, November 15, 2011, Greg KH wrote:
> On Mon, Oct 31, 2011 at 05:37:26PM -0700, Tejun Heo wrote:
> > The current implementation of set_freezable_with_signal() is buggy and
> > tricky to get right.  usb-storage is the only user and its use can be
> > avoided trivially.
> > 
> > All usb-storage wants is to be able to sleep with timeout and get
> > woken up if freezing() becomes true.  This can be trivially
> > implemented by doing interruptible wait w/ freezing() included in the
> > wait condition.  There's no reason to use set_freezable_with_signal().
> > 
> > Perform interruptible wait on freezing() instead of using
> > set_freezable_with_signal(), which is scheduled for removal.
> > 
> > Signed-off-by: Tejun Heo <tj@...nel.org>
> > Cc: Oleg Nesterov <oleg@...hat.com>
> > Cc: "Rafael J. Wysocki" <rjw@...k.pl>
> > Cc: Seth Forshee <seth.forshee@...onical.com>
> > Cc: Alan Stern <stern@...land.harvard.edu>
> > Cc: Greg Kroah-Hartman <gregkh@...e.de>
> > ---
> > 
> > These two patches are on top of "freezer: fix various bugs and
> > simplify implementation, take#2" patchset[1] and are also available in
> > the following git branch.
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git pm-kill-freezable_with_signal
> > 
> > If usb-storage ppl are okay with it, I think routing this through pm
> > would be the easiest.  Oh, and this definitely is for the next merge
> > window.
> 
> I'm fine with it going that way:
> 	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

It's there in my tree already (through the Tejun's pm-freezer branch).

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/