linux-kernel - Re: [PATCH] ARM: NUC900: add and change some device clk definitions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201111152101.51000.arnd@arndb.de>
Date:	Tue, 15 Nov 2011 21:01:50 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] ARM: NUC900: add and change some device clk definitions.

On Tuesday 15 November 2011, Wan ZongShun wrote:
> This patch is to modify usb, audio and add i2c clk setting in cpu.c.
> Also, add DMA, FMI definition to nuc900_iodesc, since I will use them
> in the corresponding driver.
> 
> ---
>  arch/arm/mach-w90x900/cpu.c |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> index 0a235e5..6eeadfc 100644
> --- a/arch/arm/mach-w90x900/cpu.c
> +++ b/arch/arm/mach-w90x900/cpu.c
> @@ -46,6 +46,8 @@ static struct map_desc nuc900_iodesc[] __initdata = {
>  	IODESC_ENT(TIMER),
>  	IODESC_ENT(EBI),
>  	IODESC_ENT(GPIO),
> +	IODESC_ENT(DMA),
> +	IODESC_ENT(FMI),
>  };

Can you change the driver to instead use ioremap with the device resources?
I think that would be much preferred. The two main uses of map_desc are
for devices that you need very early and in order to get larger than 4k
TLB entries. Neither of these seem to apply here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/