linux-kernel - Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321394084.32358.17.camel@fourier>
Date:	Tue, 15 Nov 2011 13:54:44 -0800
From:	Kamal Mostafa <kamal@...onical.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Alex Davis <alex14641@...oo.com>,
	Keith Packard <keithp@...thp.com>,
	"mjg@...hat.com" <mjg@...hat.com>, intel-gfx@...ts.freedesktop.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is
	not restored

On Tue, 2011-11-15 at 21:28 +0100, Takashi Iwai wrote:
> My rough guess is the inconsistency of property taken during the
> backlight disabled.  How about the patch below (untested!) in addition
> to the fix in 3.2?
> 
> 
> Takashi

Yes Takashi, your patch below (plus the already committed fix[0]) does
indeed fix the problem[1] for me.  Thanks!

Tested-by: Kamal Mostafa <kamal@...onical.com>

 -Kamal

[0] f52c619a590fa75276c07dfcaf380dee53e4ea4c
    drm/i915/panel: Always record the backlight level again (but cleverly)

[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652



> ---
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 499d4c0..21f60b7 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -326,7 +326,8 @@ static int intel_panel_update_status(struct backlight_device *bd)
>  static int intel_panel_get_brightness(struct backlight_device *bd)
>  {
>  	struct drm_device *dev = bl_get_data(bd);
> -	return intel_panel_get_backlight(dev);
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	return dev_priv->backlight_level;
>  }
>  
>  static const struct backlight_ops intel_panel_bl_ops = {
> 


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)